Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use async API #3719

Merged
merged 1 commit into from
Aug 25, 2021
Merged

refactor: use async API #3719

merged 1 commit into from
Aug 25, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

use async API

Breaking Changes

No

Additional Info

No

lib/Server.js Outdated Show resolved Hide resolved
lib/Server.js Outdated Show resolved Hide resolved
@snitin315 snitin315 force-pushed the refactor/use-async-api branch 2 times, most recently from 5049d19 to 6b5ae94 Compare August 25, 2021 09:23
lib/Server.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #3719 (38541d1) into master (795f8cc) will decrease coverage by 0.28%.
The diff coverage is 84.61%.

❗ Current head 38541d1 differs from pull request most recent head c0af5e0. Consider uploading reports for the commit c0af5e0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
- Coverage   92.87%   92.59%   -0.29%     
==========================================
  Files          14       14              
  Lines        1320     1323       +3     
  Branches      466      466              
==========================================
- Hits         1226     1225       -1     
- Misses         87       91       +4     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.46% <84.61%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13cd267...c0af5e0. Read the comment docs.

@alexander-akait
Copy link
Member

In future we should avoid sync API in favor async where it possible

@snitin315 snitin315 marked this pull request as ready for review August 25, 2021 10:21
@snitin315 snitin315 merged commit 8f20c3e into master Aug 25, 2021
@snitin315 snitin315 deleted the refactor/use-async-api branch August 25, 2021 12:41
@ylemkimon
Copy link
Contributor

ylemkimon commented Aug 26, 2021

Please note graceful-fs doesn't patch fs.promises APIs: isaacs/node-graceful-fs#160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants