Add unaliased path to resolve info #1548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
commented
Mar 24, 2024
| @@ -75,7 +86,8 @@ public function __construct( | |||
| ?array $positions = null, | |||
| ?array $path = null, | |||
| ?\Throwable $previous = null, | |||
| ?array $extensions = null | |||
| ?array $extensions = null, | |||
| ?array $unaliasedPath = null | |||
There was a problem hiding this comment.
I had to put this at the end to break BC.
ruudk
commented
Mar 24, 2024
Comment on lines
+1353
to
+1363
| $fieldNodes = $fields[$responseName]; | ||
| assert($fieldNodes instanceof \ArrayObject, 'The keys of $fields populate $responseName'); | ||
|
|
||
| $fieldPath = $path; | ||
| $fieldPath[] = $responseName; | ||
| $result = $this->resolveField($parentType, $rootValue, $fieldNodes, $fieldPath, $this->maybeScopeContext($contextValue)); | ||
|
|
||
| $fieldNode = $fieldNodes[0]; | ||
| assert($fieldNode instanceof FieldNode, '$fieldNodes is non-empty'); | ||
|
|
||
| $fieldUnaliasedPath = $unaliasedPath; | ||
| $fieldUnaliasedPath[] = $fieldNode->name->value; |
There was a problem hiding this comment.
Same as executeFieldsSerially
ruudk
commented
Mar 24, 2024
Comment on lines
+588
to
+594
| * @param mixed $rootValue | ||
| * @param array<int, string|int> $path | ||
| * @param array<int, string|int> $unaliasedPath | ||
| * @param mixed $contextValue | ||
| * | ||
| * @phpstan-param Path $path | ||
| * @phpstan-param Path $path | ||
| * @phpstan-param Path $unaliasedPath |
There was a problem hiding this comment.
It would be great if phpdoc_align was set to left, to not cause all these changes.
ruudk
commented
Mar 24, 2024
| * Returns an array describing the path from the root value to the field which produced this error. | ||
| * Only included for execution errors. This will never include aliases. | ||
| * | ||
| * @return array<int, int|string>|null |
There was a problem hiding this comment.
I kept it array<int, int|string> to be the same as path, but personally I would make this a list<int|string>.
|
@spawnia This one is ready for review, when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345