Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between const and non-const AST nodes #1335

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Differentiate between const and non-const AST nodes #1335

wants to merge 14 commits into from

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Mar 3, 2023 •
edited

  • Check where ConstValueNode needs to be used

@spawnia spawnia changed the title Add AST type ConstValueNode Differentiate between const and non-const AST nodes Mar 8, 2023
@spawnia spawnia requested a review from simPod March 8, 2023 13:43
simPod
simPod reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not really able to evaluate this addition since I don't have the required gql expertise but I don't see any harm in this either.

src/Validator/Rules/UniqueInputFieldNames.php Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simPod simPod simPod left review comments

Assignees
No one assigned
Labels
BC break enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spawnia @simPod