Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcode French help file to UTF-8. #1032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

transcode French help file to UTF-8. #1032

wants to merge 1 commit into from

Conversation

zeroheure
Copy link
Contributor

No description provided.

@zeroheure zeroheure mentioned this pull request Mar 2, 2019
@jcameron
Copy link
Collaborator

jcameron commented Mar 2, 2019

Thanks, but this file shouldn't be in UTF-8 encoding - those go in a separate file that is generated from it as part of Webmin's packaging process.

@dktcoding
Copy link

Is there a specific reason behind this? Related to #1041

@iliajie
Copy link
Collaborator

iliajie commented Apr 15, 2019

Can you please commit to non unicode variant of the file, preserving initial encoding?

@zeroheure
Copy link
Contributor Author

@rostovtsev I don't understand : I've just re-encoded the file to UTF8

@iliajie
Copy link
Collaborator

iliajie commented May 27, 2019

@zeroheure At the moment, upon compilation, Webmin uses non-UTF variant of language file, and generates UTF-8 file. UTF-8 files are not supposed to be on the repo at all, as they are regenerated.

@jcameron Jamie, how much time it would take to do the opposite. Store all files in UTF-8 and transcode to other encodings if necessary (internally, so users would only face/deal with UTF-8 files to prevent encoding issues)?

@jcameron
Copy link
Collaborator

Yes, this is in progress. I'm doing some work right now to fix up existing encodings, in preparation for UTF-8 conversion.

@zeroheure
Copy link
Contributor Author

@rostovtsev Looks like it doesn't work well for french as many generated files are not UTF-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants