Fixed: Outdated update query string parameters #3

webmarketingroi · May 8, 2017 · a994962 · a994962
1 parent 6427ed5
commit a994962
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/WebMarketingROI/OptimizelyPHP/Service/v2/Experiments.php b/lib/WebMarketingROI/OptimizelyPHP/Service/v2/Experiments.php
@@ -163,12 +163,11 @@ public function create($experiment, $action = null)
      * Update an Experiment by ID
      * @param integer $experimentId
      * @param Experiment $experiment
-     * @param boolean $overrideChanges If there are draft changes already in the experiment, you can override those changes by providing this query parameter.
-     * @param boolean $publish Whether to publish the changes to the world.
+     * @param string $action Action to change the state of the Experiment. 
      * @return Result
      * @throws Exception
      */
-    public function update($experimentId, $experiment, $overrideChanges, $publish) 
+    public function update($experimentId, $experiment, $action) 
     {
         if (!is_int($experimentId)) {
             throw new Exception("Expected argument of type Experiment");
@@ -183,8 +182,7 @@ public function update($experimentId, $experiment, $overrideChanges, $publish)
         }
 
         $queryParams = array(
-            'override_changes' => $overrideChanges,
-            'publish' => $publish
+            'action' => $action
         );
 
         $postData = $experiment->toArray();

diff --git a/tests/OptimizelyPHPTest/Service/v2/ExperimentsTest.php b/tests/OptimizelyPHPTest/Service/v2/ExperimentsTest.php
@@ -720,7 +720,7 @@ public function testUpdate()
               )
         ));
 
-        $result = $experimentsService->update(1000, $experiment, true, true);
+        $result = $experimentsService->update(1000, $experiment, 'start');
         $updatedExperiment = $result->getPayload();
 
         $this->assertTrue($updatedExperiment instanceOf Experiment);
@@ -943,7 +943,7 @@ public function testIntegration()
 
         // Update experiment
         $createdExperiment->setName('Some new experiment name');
-        $result = $optimizelyClient->experiments()->update($createdExperiment->getId(), $createdExperiment);
+        $result = $optimizelyClient->experiments()->update($createdExperiment->getId(), $createdExperiment, 'start');
         $updatedExperiment = $result->getPayload();                
 
         $this->assertTrue($updatedExperiment instanceOf Experiment);