Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactions to comments #3584

Merged
merged 4 commits into from
May 23, 2024
Merged

Add reactions to comments #3584

merged 4 commits into from
May 23, 2024

Conversation

falbru
Copy link
Contributor

@falbru falbru commented Mar 28, 2024

A lot of this is "cooked" from this PR. I have provided more details about my implementation in my frontend PR.

@falbru falbru requested a review from a team March 28, 2024 12:42
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (be1c3ee) to head (c324a04).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3584      +/-   ##
==========================================
+ Coverage   89.04%   89.15%   +0.11%     
==========================================
  Files         677      682       +5     
  Lines       21256    21437     +181     
==========================================
+ Hits        18927    19113     +186     
+ Misses       2329     2324       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love some tests:)

@falbru falbru force-pushed the add-reactions-to-comments branch 3 times, most recently from d59730a to 28f575a Compare May 22, 2024 21:01
@falbru falbru requested a review from eikhr May 22, 2024 21:03
@falbru falbru force-pushed the add-reactions-to-comments branch from 28f575a to c324a04 Compare May 22, 2024 21:06
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@falbru falbru merged commit 99fb7e5 into master May 23, 2024
3 checks passed
@falbru falbru deleted the add-reactions-to-comments branch May 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants