Map over list of eventComment

[Arashfa0301]

Description

Improved companyInterestPage by mapping over a list of eventComment field instead of directly having the code snippets for each comment

Testing

• I have thoroughly tested my changes.

[ivarnakken]

haha sorry, but you'll have to change up the logic here with the migration over to react-final-form. The values need to be spied on, like in the new version of the code. Should be simple to do though.

[LudvigHz]

It makes more sense to filter the list instead. Either here or in the declaration.

[Arashfa0301]

This code snippet is now updated. Could you check and tell me if filtering is needed now or not.

[Arashfa0301]

I could try to put showComment and the spyValue part in the eventCommentFields list, but maybe filtering isn't necessary now??

[norbye]

LGTM:) lots of love for the reduction of duplicate code

[norbye]

Haven't looked into how these values work exactly, so I'm just throwing it out there so you can decide if it makes sense.

As you're checking the array for events that are .checked (I assume that you have covered all the event names in the array above - so that the e.name === event.name check would only make sure that specific event is checked), could it be an option to instead do something like the following?

spyValues((values: CompanyInterestFormEntity) => 
    values.events?.filter(event => event.checked).map(event => {
        const eventFields = eventCommentFields[event.name]
        return (...);
    })
)

For it to make sense, eventCommentFields would need to be an object with what is currently the name: "" value as the key.

Just an alternative approach to do the same thing, but it would shorten it down a little bit more, and remove the need for the some() calls and boolean values making it a little bit more readable(:

[eikhr]

➕

[PeterJFB]

+1 on @norbye comment, then

[eikhr]

Huge improvement! I like @norbye's suggestion, but I think it's fine as it is too:)

[eikhr]

➕

[ivarnakken]

@Arashfa0301 Any updates on this? Would be nice to eventually get it in

[eikhr]

@Arashfa0301 can we get this merged?

[ivarnakken]

@Arashfa0301