Fix blur artifacts with odd filter size #181

jereroy · 2022-05-12T02:21:41Z

austinEng

thank you for the contribution! sorry it took a while for me to review this

austinEng · 2022-06-03T21:35:33Z

src/sample/imageBlur/main.ts

@@ -222,6 +222,8 @@ const init: SampleInit = async ({ canvasRef, gui }) => {

  let blockDim: number;
  const updateSettings = () => {
+    settings.filterSize += 1;


instead of += 1, I think it would be better to change the computations below so that they are settings.filterSize and settings.filterSize + 1 instead of settings.filterSize - 1 and settings.filterSize

Fix blur artifacts with odd filter size

17c54a9

austinEng reviewed Jun 3, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix blur artifacts with odd filter size #181

Fix blur artifacts with odd filter size #181

jereroy commented May 12, 2022

austinEng left a comment

austinEng Jun 3, 2022

Fix blur artifacts with odd filter size #181

Are you sure you want to change the base?

Fix blur artifacts with odd filter size #181

Conversation

jereroy commented May 12, 2022

austinEng left a comment

Choose a reason for hiding this comment

austinEng Jun 3, 2022

Choose a reason for hiding this comment