fixed parsing the timezone when reading API response #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ralf, since you created this Pull Request we released a contributing guide. In order for us to properly merge this pull request, it must meet the standards of the guide. Can you please adjust the git commit message[s] to match the requirements of the guide. We would at least need a header and a body for the commit. Thanks |
jbenyovs
approved these changes
Nov 8, 2019
|
@jbenyovs it doesn't look like the original PR submitter will be replying back. Would you be able to fix this bug out of band? It seems strange that a 3 character fix has been blocked for 3 years because the submitter went away. Without this simple fix the timestamps (e.g., last activity) are consistently off by several hours unless you happen to live in GMT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parse the timezone in the API response wrong. This is before the fix when I query any resource like people/me
people/me
API response
"created": "2017-10-26T23:11:32.021Z",
"lastActivity": "2019-02-22T19:03:25.661Z",
"status": "inactive",
SDK response
created: Thu Oct 26 23:11:32 PDT 2017
lastActivity: Fri Feb 22 19:03:25 PST 2019
This is after the fix with the correct translation of Zulu time to local time
Thu Oct 26 16:11:32 PDT 2017
Fri Feb 22 11:03:25 PST 2019