Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Upgrade to latest cucumber 3.2.1 #88

Closed
wants to merge 2 commits into from

Conversation

devth
Copy link

@devth devth commented Jan 9, 2018

Not sure what all needs to happen to support upgrading but thought I'd start the conversation here.

@jsf-clabot
Copy link

jsf-clabot commented Jan 9, 2018

CLA assistant check
All committers have signed the CLA.

@christian-bromann
Copy link
Contributor

christian-bromann commented Jan 9, 2018

@devth as you can see in the tests, some of the integrations are failing. There are some breaking changes that need to get adapted here first. Any help is appreciated.

@devth
Copy link
Author

devth commented Jan 9, 2018

Yep, I see. Any plans to make them? Should I dive in and try or is it a pretty involved task?

@christian-bromann
Copy link
Contributor

Any plans to make them?

Not my highes priority right now

Should I dive in and try or is it a pretty involved task?

No, feel free to look into it

@devth
Copy link
Author

devth commented Jan 9, 2018

Ok will do! (Reason is I want to use BeforeAll then realized wdio was using an older version before BeforeAll was introduced.)

@devth
Copy link
Author

devth commented Jan 10, 2018

npm 5.x generates a package-lock.json to lock down dep versions. Want me to add it as part of this PR?

@christian-bromann
Copy link
Contributor

Want me to add it as part of this PR?

Sure

@devth
Copy link
Author

devth commented Jan 10, 2018

This might be as far as I get for now. Confused by test errors and it looks like it'll require a lot of changes.

@ashmind
Copy link

ashmind commented Feb 4, 2018

I did some research on this one — for 4.0.0, but I think it's the same issues.

The test fail with {stringInDoubleQuotes} is easy to fix — can be replaced with {string}.

However, there is also a change in how hooks are implemented. My understanding is that the hooks from before supported async handlers, but latest Cucumber uses EventEmitter without async support. I considered using Before/After instead, however that's only for scenarios. BeforeStep is considered (cucumber/cucumber-js#997), but not implemented yet.

I'm hardly an expert on this, but feels like this is blocked until there are some changes in Cucumber.

@christian-bromann
Copy link
Contributor

Fixed by #104

@devth devth deleted the patch-1 branch April 20, 2018 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants