Fix invalid rule warning at startup #9
Conversation
"systemd-udevd[52]: /etc/udev/rules.d/90-storaged.rules:20 Invalid value "/etc/udev/scripts/storage.sh $ENV{G_ACTION} $ENV{G_MEDIA_LOADED}$ENV{G_HOST_CONNECTED}$ENV{G_MEDIA_REQUESTED}$ENV{G_BUS_SUSPENDED}" for RUN (char 30: invalid substitution type), ignoring."
| @@ -17,7 +17,7 @@ | |||
| # LICENSE@@@ | |||
|
|
|||
|
|
|||
| KERNEL=="usb_gadget", SUBSYSTEM=="platform", DRIVER=="usb_gadget", ENV{G_SUBSYSTEM}=="storage", ACTION=="change", RUN+="@WEBOS_INSTALL_SYSCONFDIR@/udev/scripts/storage.sh $ENV{G_ACTION} $ENV{G_MEDIA_LOADED}$ENV{G_HOST_CONNECTED}$ENV{G_MEDIA_REQUESTED}$ENV{G_BUS_SUSPENDED}" | |||
There was a problem hiding this comment.
@WEBOS_INSTALL_SYSCONFDIR@ should be replaced by during build by /etc. So the actual issue might be just the missing /bin/sh somehow? Really not sure here. Seems legacy had the following:
# route mass storage events to storaged over lunaservice bus KERNEL=="usb_gadget", SUBSYSTEM=="platform", DRIVER=="usb_gadget", ENV{G_SUBSYSTEM}=="storage", ACTION=="change", RUN+="/etc/udev/scripts/storage.sh $ENV{G_ACTION} $ENV{G_MEDIA_LOADED}$ENV{G_HOST_CONNECTED}$ENV{G_MEDIA_REQUESTED}$ENV{G_BUS_SUSPENDED}"
There was a problem hiding this comment.
The syntax is just wrong. Per the manual page, https://man7.org/linux/man-pages/man7/udev.7.html
Search for "The RUN substitutions are performed after all rules", to find the correct syntax for substitution inside a field. The ENV{} syntax is correct for G_SUBSYSTEM but $env{key} is correct for inside the RUN. It is case-sensitive, $ENV is not $env
"systemd-udevd[52]: /etc/udev/rules.d/90-storaged.rules:20 Invalid value "/etc/udev/scripts/storage.sh $ENV{G_ACTION} $ENV{G_MEDIA_LOADED}$ENV{G_HOST_CONNECTED}$ENV{G_MEDIA_REQUESTED}$ENV{G_BUS_SUSPENDED}" for RUN (char 30: invalid substitution type), ignoring."
It is not clear that this will actually make usb gadget functionality work, but it's a step there. We should get ahold of a legacy system and see how this is handled.