nyx-modules: only bring in libcec-examples and nyx modules for CEC on Pi4 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Pi4 - Per comments in packagegroup-luneos-extended.bbappend, CEC is only supported on Pi4
shr-project
reviewed
Mar 1, 2024
|
|
||
| RDEPENDS:${PN}:append:rpi = " libcec-examples" | ||
| # packagegroup-luneos-extended says CEC is only supported on pi4-64 |
There was a problem hiding this comment.
I don't think there is technical reason for it to work only on pi4-64, it's just what they tested in:
webosose/meta-webosose@fcb5874
shr-project
reviewed
Mar 1, 2024
|
|
||
| NYX_MODULES_REQUIRED:append:rpi = "NYXMOD_OW_CEC;" | ||
| NYX_MODULES_REQUIRED:append:raspberrypi4-64 = "NYXMOD_OW_CEC;" |
There was a problem hiding this comment.
it's enabled for all rpi MACHINEs in upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not have hardware to test if this is actually true, but figure the code in the packagegroup should match the code in nyx-modules