Remove override for fkms driver, use kms driver on Pi3 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested by building an image, validating the config.txt contains the correct kms and gpu_mem, and then booting it on a Pi3B |
- kms driver works on Pi3, and provides a significantly smoother/faster user experience, and allows for much lower gpu_mem split - Increase default gpu_mem, as LuneOS vkb does not work at 1080p display modes, without increasing gpu_mem split to 160mb (with either fkms or kms) - Allow overriding of GPU_MEM by user, as gpu_mem settings as low as 16mb work if you are not using 1080p display modes. This allows someone targetting lower resolutions explicitly to gain a significant amount of resources back. - Untested on other Pi models, but I would expect it would work, as all Pi models share the kms driver.
|
No way to test it here, but trust you on it. LGTM |
Did you test hdmi audio with this change? I had similar change internally and in the end it was rejected due to some audio related issues. |
|
@shr-project As far as I can tell HDMI audio works - startup and shutdown sounds occur, and with less crackling than without this. There's not much else I can test on device without html audio working, and it's my understanding that html audio is not working across the board. The only audio output I have connected is HDMI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user experience, and allows for much lower gpu_mem split
modes, without increasing gpu_mem split to 160mb (with either fkms or
kms)
work if you are not using 1080p display modes. This allows someone
targetting lower resolutions explicitly to gain a significant amount of
resources back.
Pi models share the kms driver.