web3 external provider - Quicknode #7019
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: e8b76d6 | Previous: 692987a | Ratio |
|---|---|---|---|
processingTx |
9142 ops/sec (±4.03%) |
8880 ops/sec (±3.76%) |
0.97 |
processingContractDeploy |
37170 ops/sec (±7.42%) |
38813 ops/sec (±6.13%) |
1.04 |
processingContractMethodSend |
19404 ops/sec (±6.37%) |
18943 ops/sec (±7.10%) |
0.98 |
processingContractMethodCall |
38963 ops/sec (±4.83%) |
38006 ops/sec (±5.78%) |
0.98 |
abiEncode |
45518 ops/sec (±6.68%) |
43737 ops/sec (±6.49%) |
0.96 |
abiDecode |
30506 ops/sec (±7.40%) |
29525 ops/sec (±8.05%) |
0.97 |
sign |
1571 ops/sec (±0.78%) |
1523 ops/sec (±3.37%) |
0.97 |
verify |
368 ops/sec (±0.68%) |
371 ops/sec (±0.54%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7019 +/- ##
==========================================
- Coverage 92.21% 92.19% -0.03%
==========================================
Files 215 215
Lines 8329 8330 +1
Branches 2296 2297 +1
==========================================
- Hits 7681 7680 -1
- Misses 648 650 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
requested changes
May 17, 2024
| case Network.ETH_MAINNET: | ||
| host = isValid(_host) ? _host : "powerful-holy-bush.quiknode.pro"; | ||
| token = isValid(_token) ? _token : "3240624a343867035925ff7561eb60dfdba2a668"; | ||
| break; |
There was a problem hiding this comment.
is it ok to have tokens here?
There was a problem hiding this comment.
yes, these are public tokens
luu-alex
reviewed
May 17, 2024
packages/web3-providers/package.json
Outdated
| @@ -0,0 +1,66 @@ | |||
| { | |||
| "name": "web3-providers", | |||
| "version": "0.1.0", | |||
There was a problem hiding this comment.
if we start at 0.1.0 that would that be considered alpha
There was a problem hiding this comment.
yes, 1.0.0 will be prod
avkos
approved these changes
May 21, 2024
|
Failing testcases, otherwise it looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6976
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.