New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples tx 0, 1 and 2 #7006
base: 4.x
Are you sure you want to change the base?
Examples tx 0, 1 and 2 #7006
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 1b0e82e | Previous: 88b7e2e | Ratio |
---|---|---|---|
processingTx |
9303 ops/sec (±4.05% ) |
9219 ops/sec (±3.36% ) |
0.99 |
processingContractDeploy |
39879 ops/sec (±7.06% ) |
38213 ops/sec (±7.03% ) |
0.96 |
processingContractMethodSend |
18805 ops/sec (±7.02% ) |
19245 ops/sec (±6.02% ) |
1.02 |
processingContractMethodCall |
40348 ops/sec (±5.21% ) |
38559 ops/sec (±4.51% ) |
0.96 |
abiEncode |
44703 ops/sec (±6.89% ) |
41839 ops/sec (±8.41% ) |
0.94 |
abiDecode |
29396 ops/sec (±8.82% ) |
30277 ops/sec (±6.54% ) |
1.03 |
sign |
1604 ops/sec (±0.67% ) |
1556 ops/sec (±3.30% ) |
0.97 |
verify |
373 ops/sec (±2.63% ) |
374 ops/sec (±0.46% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7006 +/- ##
==========================================
+ Coverage 87.37% 91.98% +4.60%
==========================================
Files 197 215 +18
Lines 7548 8292 +744
Branches 2059 2277 +218
==========================================
+ Hits 6595 7627 +1032
+ Misses 953 665 -288
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already have example of all tx types. The question was to show how to send contract transaction with different types. For ex. Transfer ERC20 token using tx 0,1,2
@avkos this one looks better now!💪 |
lgtm, except Oleksii suggestion. |
closing #5732