Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples tx 0, 1 and 2 #7006

Open
wants to merge 9 commits into
base: 4.x
Choose a base branch
from
Open

Examples tx 0, 1 and 2 #7006

wants to merge 9 commits into from

Conversation

SantiagoDevRel
Copy link
Member

closing #5732

Copy link

github-actions bot commented Apr 25, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 623.22 kB → 624.29 kB (+1.06 kB) +0.17%
Changeset
File Δ Size
../web3-eth/lib/commonjs/index.js 📈 +980 B (+26.10%) 3.67 kB → 4.62 kB
../web3-eth/lib/commonjs/utils/watch_transaction_for_confirmations.js 📈 +240 B (+9.21%) 2.54 kB → 2.78 kB
../web3-eth/lib/commonjs/utils/watch_transaction_by_polling.js 📈 +152 B (+5.38%) 2.76 kB → 2.91 kB
../web3-eth/lib/commonjs/utils/watch_transaction_by_subscription.js 📈 +252 B (+5.25%) 4.69 kB → 4.94 kB
../web3-eth/lib/commonjs/utils/wait_for_transaction_receipt.js 📈 +137 B (+3.58%) 3.74 kB → 3.87 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +64 B (+0.73%) 8.54 kB → 8.6 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 604.16 kB → 604.99 kB (+852 B) +0.14%
../lib/commonjs/types.d.ts 2.45 kB → 2.67 kB (+234 B) +9.34%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 1b0e82e Previous: 88b7e2e Ratio
processingTx 9303 ops/sec (±4.05%) 9219 ops/sec (±3.36%) 0.99
processingContractDeploy 39879 ops/sec (±7.06%) 38213 ops/sec (±7.03%) 0.96
processingContractMethodSend 18805 ops/sec (±7.02%) 19245 ops/sec (±6.02%) 1.02
processingContractMethodCall 40348 ops/sec (±5.21%) 38559 ops/sec (±4.51%) 0.96
abiEncode 44703 ops/sec (±6.89%) 41839 ops/sec (±8.41%) 0.94
abiDecode 29396 ops/sec (±8.82%) 30277 ops/sec (±6.54%) 1.03
sign 1604 ops/sec (±0.67%) 1556 ops/sec (±3.30%) 0.97
verify 373 ops/sec (±2.63%) 374 ops/sec (±0.46%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (4358140) to head (1b0e82e).
Report is 233 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7006      +/-   ##
==========================================
+ Coverage   87.37%   91.98%   +4.60%     
==========================================
  Files         197      215      +18     
  Lines        7548     8292     +744     
  Branches     2059     2277     +218     
==========================================
+ Hits         6595     7627    +1032     
+ Misses        953      665     -288     
Flag Coverage Δ
UnitTests 91.98% <ø> (+4.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have example of all tx types. The question was to show how to send contract transaction with different types. For ex. Transfer ERC20 token using tx 0,1,2

docs/docs/guides/wallet/transactions.md Show resolved Hide resolved
@SantiagoDevRel
Copy link
Member Author

@avkos this one looks better now!💪

@jdevcs
Copy link
Contributor

jdevcs commented May 2, 2024

I think we already have example of all tx types. The question was to show how to send contract transaction with different types. For ex. Transfer ERC20 token using tx 0,1,2

lgtm, except Oleksii suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants