New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded web3config Guide #6839
base: 4.x
Are you sure you want to change the base?
Conversation
@@ -30,6 +30,55 @@ There is list of configuration params that can be set for modifying behavior of | |||
|
|||
## Global level Config | |||
|
|||
`handleRevert` is a configuration option that specifies whether the web3 provider should handle revert errors automatically. When set to true, the web3 provider will catch revert errors and return a more informative error message instead of throwing an exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeenuyD Thanks for working on this, I'll suggest to create a new section in this guide, for explaning config options, and we need desc of all of following config params:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
& if you open docs for these params in https://docs.web3js.org/guides/web3_config/ there is already desc that can be reused in this new section,
as second step I'll suggest to add code snippets as well in doc as examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeenuyD let us know when updates are complete, thx
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6839 +/- ##
==========================================
+ Coverage 87.37% 92.05% +4.68%
==========================================
Files 197 215 +18
Lines 7548 8206 +658
Branches 2059 2208 +149
==========================================
+ Hits 6595 7554 +959
+ Misses 953 652 -301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait for changes
Expanded web3config Guide in Documentation: Added explanations and code samples for handleRevert and defaultAccount parameters.
#6805