Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix youtube-music connector on Firefox #4704

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

1shira
Copy link
Contributor

@1shira 1shira commented May 12, 2024

Describe the changes you made
Previous implementation was not able to access the navigator object on Firefox, making the extention unable to detect music on Firefox
see #4613 (comment)

Added inject script for youtube music to access the navigator object on Firefox and send data to the connector.

Additional context
Fixes #4613

@1shira 1shira changed the title fix youtube-music connector on Firefox fix youtube-music connector on Firefox (#4513) May 13, 2024
@1shira 1shira changed the title fix youtube-music connector on Firefox (#4513) fix youtube-music connector on Firefox May 13, 2024
@inverse inverse assigned inverse and unassigned inverse May 13, 2024
@inverse inverse added patch-change For patch changes fixed-connector for PRs that fix a connector labels May 13, 2024
@inverse inverse requested a review from yayuyokitano May 15, 2024 17:49
@inverse inverse merged commit 823ead6 into web-scrobbler:master May 26, 2024
13 of 14 checks passed
@inverse
Copy link
Member

inverse commented May 26, 2024

Thanks!

@inverse inverse added minor-change For minor changes patch-change For patch changes and removed patch-change For patch changes minor-change For minor changes labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-connector for PRs that fix a connector patch-change For patch changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

music.youtube.com connector doesn't work for a few days
2 participants