Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tag matching logic for Bilibili connector #4639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turbodog03
Copy link
Contributor

Describe the changes you made
If there is an exact match between a tag and a possible Artist/Track, it should be used as the Artist/Track.

For example:
when detected these possible artist and tags:

Video Title:【Official Music Video】輪符雨(Refrain)/ MyGO!!!!!【原创歌曲】
PossibleArtist: Official Music Video,MyGO_AveMujica,MyGO!!!!!
FilteredTags: MyGO!!!!!,mygo

Obviously, MyGO!!!!! is the artist name, and there is a tag that exactly matches it. But there's also a tag named mygo. According to the previous logic, mygo could be recognized as artist, instead of the obvious correct answer(which is confusing)

@inverse inverse added updated For things that were updated, e.g. connectors, icons patch-change For patch changes labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-change For patch changes updated For things that were updated, e.g. connectors, icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants