Add connector for VocaDB / UtaiteDB / TouhouDB #4638
Conversation
Revised from web-scrobbler#3596
Revised from web-scrobbler#3596
inverse
added
new-connector
There was a problem hiding this comment.
Changes seem fine aside the brittle comment on the selectors. Is there anything that can be done?
@hornbuckle do you have anything to add as you reviewed the previous pull request?
| } | ||
| } | ||
|
|
||
| Connector.playerSelector = '#app .css-1pm1wrk'; |
There was a problem hiding this comment.
These selectors still feel quite brittle to any new deployment as mentioned in #3596 (comment)
Is there any other way the selection could be done?
There was a problem hiding this comment.
@inverse Looks like the same previously suggested selectors noted in #3596 (comment) will still work.
There was a problem hiding this comment.
@sorusari343 could you change to use the selectors noted above and fix the linting issues? Or would you like me to help with that?
There was a problem hiding this comment.
Sorry, I didn't see these replies earlier. I think the website has been through a few software updates and the selectors seem to still work, and as such, I did not give that part much thought. I turned edits by maintainers on, so please do whatever is necessary.
Describe the changes you made
Connector for https://vocadb.net/ and related websites
Revised from #3596
Additional context