Update ZONE connector #4532
Open
Update ZONE connector #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
added
updated
Update src/connectors/zeno.ts Co-authored-by: yayuyokitano <69117606+yayuyokitano@users.noreply.github.com> Update src/connectors/zeno.ts Co-authored-by: yayuyokitano <69117606+yayuyokitano@users.noreply.github.com> Apply suggestions from code review Co-authored-by: yayuyokitano <69117606+yayuyokitano@users.noreply.github.com> npm run prettierfix
| // There seems to be some kind of race condition here because we should expect the <audio>.paused state to be inverted. | ||
| // But that's how it works now and the play/pause button toggles the states correctly. | ||
| return !!( | ||
| document.querySelector('#audioPlayer') && |
There was a problem hiding this comment.
Suggested change
| document.querySelector('#audioPlayer') && |
This is redundant, as the null check is already handled by optional chaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the connector is updated to changes on the site