Update securenetsystems.ts — DOM Changed #4516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayuyokitano
added
updated
src/connectors/securenetsystems.ts
Outdated
Comment on lines
23
to
24
| let computedStyle = window.getComputedStyle('.progressBar'); | ||
| let durationInSeconds = computedStyle.getPropertyValue('transition-duration'); |
There was a problem hiding this comment.
This doesn't work. Try using const durationInSeconds = Util.getCSSPropertyFromSelectors('.progressBar', 'transition-duration')
|
Thank you for the contribution! See comment above. |
|
@yayuyokitano thanks for the review. I'll take a look later at #3470 to do a proper vetting, and add back in whatever is necessary 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you made
Wasn't selecting the correct elements anymore. Duration was also changed from being displayed to being a
transition-durationon a progress bar element.Was using WWCD's stream to run against.