[css-color] test conversion lossiness in relative color syntax #45148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
changed the title
svgeesus
approved these changes
Mar 18, 2024
romainmenke
deleted the
css-color-test-conversion-lossiness--resourceful-pekingese-64ad5cfa3d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative color syntax is expected to be somewhat resilient to cumulative errors.
Converting from A to B and back to A should result in the original value up to a some precision. This is only a single round trip.
I am making the assumption that implementers are using either
xyz-d50orxyz-d65as intermediary space to convert color values for features likecolor-mixand relative color syntax. This is also what I did.This tests that converting from
xyz-d50to another notation and back results in the original value. The same forxyz-d60.It is currently unspecified what the internal precision must be for color values.
css-color-4only defined precision for serialization. I've now used 5 decimal places which I think is fairly reasonable. It based on the serialization precision forcolor(xyz ...), which is 16 bits.