Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-color] fix some outdated tests #45146

Merged
merged 1 commit into from Mar 18, 2024
Merged

[css-color] fix some outdated tests #45146

merged 1 commit into from Mar 18, 2024

Conversation

romainmenke
Copy link
Contributor

@romainmenke romainmenke commented Mar 16, 2024 •
edited

  • some tests had fairly low precision
  • tests that mixed alpha and channel positions weren't up to date
  • tests with none for relative rgb, hsl and hwb were bogus
  • here and there a typo seems to have occurred

@svgeesus svgeesus merged commit 1a88768 into web-platform-tests:master Mar 18, 2024
19 checks passed
@romainmenke romainmenke deleted the css-color-fix-tests--adventurous-termite-365f9056e9 branch March 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svgeesus svgeesus svgeesus approved these changes

@dbaron dbaron Awaiting requested review from dbaron

@tabatkins tabatkins Awaiting requested review from tabatkins

@weinig weinig Awaiting requested review from weinig

Assignees

@tabatkins tabatkins

Labels
css-color
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romainmenke @svgeesus @tabatkins @wpt-pr-bot