add test for invalid ancillary after IDAT #44936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ProgramMax @annevk any chance of a quick review? |
ProgramMax
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the other invalid ancillary test but here, the invalid chunk is after
IDATrather than before it.The test PNG was created from a copy of the valid reference PNG; I inserted a
tRNSchunk in TweakPNG, moved it afterIDAT(accepting the warning) and saved. Then in a hex editor I changed "N" (0x4E) to 0x0E, saved, ran it through PNG file chunk inspector to get the new CRC value, and typed that in in a hex editor.Chunk summary:
IHDR,gAMA,PLTE,IDAT,tR␎S,IEND