Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation API test #2432

Merged
merged 3 commits into from
Feb 17, 2016
Merged

Presentation API test #2432

merged 3 commits into from
Feb 17, 2016

Conversation

louaybassbouss
Copy link
Contributor

Dear all,

I am the Test Facilitator of the W3C Presentation API. This PR contains the initial folder structure and idlharness of the API for controlling and receiving user agents. I am happy to hear your feedback.

Thx,
Louay

…w.w3.org/TR/presentation-api/) tests is added. It contains two subfolders `controlling-ua` and `receiving-ua` for testing the API on controlling and receiving user agents.

* initial `idlharness.html` is added for controlling and receiving user agents.
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6051

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@tobie
Copy link
Contributor

tobie commented Dec 15, 2015

Reviewers for this pull request are: @w3c/presentation-api-reviewers.

@zqzhang
Copy link
Contributor

zqzhang commented Dec 17, 2015

w3c-test:mirror

@zqzhang
Copy link
Contributor

zqzhang commented Dec 17, 2015

Feel free to try the tests at
http://w3c-test.org/submissions/2432/presentation-api/

* update idlharness.html with latest Presentation API interfaces from the ED
@mfoltzgoogle
Copy link
Member

Thanks for kicking this off @louaybassbouss. Tests LGTM

readonly attribute PresentationConnectionState state;
void close();
void terminate();
attribute EventHandler onstatechange;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems the spec has some changes at w3c/presentation-api#227

Would you please update the IDL accordingly? Or shall we merge this as-is and address IDL update in following PRs?

Maybe you can add a comment in the test file to reflect the spec date for tracking.

@zqzhang
Copy link
Contributor

zqzhang commented Dec 23, 2015

LGTM with nit.

@zqzhang
Copy link
Contributor

zqzhang commented Feb 17, 2016

As @louaybassbouss committed to keep the IDL up-to-date with the spec at w3c/presentation-api#266 (comment), I would like to land the initial pull request as-is.

zqzhang pushed a commit that referenced this pull request Feb 17, 2016
@zqzhang zqzhang merged commit ad9a339 into web-platform-tests:master Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants