Skip to content

Commit

Permalink
Revert "Reland "Reland "Service worker web platform tests."""
Browse files Browse the repository at this point in the history
This reverts commit 9bd67ed90e90d6a2c2134d26bb8bcc4cd9436b19.

Reason for revert: Failing in some cases.

Original change's description:
> Reland "Reland "Service worker web platform tests.""
>
> This reverts commit 93a580699ecf6d102a5853455b5faeceea4cd31e.
>
> Reason for revert: Removed the test case that times out,
> (the one that waits for the update url).
>
> Original change's description:
> > Revert "Reland "Service worker web platform tests.""
> >
> > This reverts commit 436f1b9f6153002fd41599d5d4ec8343cf930a43.
> >
> > Reason for revert: There are still timeouts in some tests
> >
> > Original change's description:
> > > Reland "Service worker web platform tests."
> > >
> > > This reverts commit 36a1c457dac0ecaa54c0553b28f67c0c61752494.
> > >
> > > Reason for revert: The test that looks for 'update-url.py' takes too long and therefore will require this test file to be part of slowTests
> > >
> > > Original change's description:
> > > > Revert "Service worker web platform tests."
> > > >
> > > > This reverts commit 63858f1b1ed058d07e73cebb0a98214aa2cfc715.
> > > >
> > > > Reason for revert: New test added; fails immediately on some bots.
> > > >
> > > > See
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/38089/overview
> > > > for the first failures. (And consistently in subsequent builds)
> > > >
> > > > Original change's description:
> > > > > Service worker web platform tests.
> > > > >
> > > > > This tests that when an auction is ran, service workers do not intercept requests with URLs that are meant to be private.
> > > > >
> > > > >
> > > > > Bug: 293383734
> > > > > Change-Id: I06858f7cae4794a35c045fb8dad30d6316a26ead
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459094
> > > > > Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
> > > > > Reviewed-by: mmenke <mmenke@chromium.org>
> > > > > Reviewed-by: Orr Bernstein <orrb@google.com>
> > > > > Cr-Commit-Position: refs/heads/main@{#1294960}
> > > >
> > > > Bug: 293383734
> > > > Change-Id: I3431f0e45e65767ff1529002d8a2d14657d0cb5a
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5506634
> > > > Auto-Submit: Ian Clelland <iclelland@chromium.org>
> > > > Owners-Override: Ian Clelland <iclelland@chromium.org>
> > > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > > Cr-Commit-Position: refs/heads/main@{#1295015}
> > >
> > > Bug: 293383734
> > > Change-Id: I762dd50282f99617796df64d73a27d149cac0a86
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512083
> > > Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Reviewed-by: Orr Bernstein <orrb@google.com>
> > > Reviewed-by: mmenke <mmenke@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1296948}
> >
> > Bug: 293383734
> > Change-Id: I9b06c0453656aaa448d0030960a48fc264bcf867
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515623
> > Auto-Submit: Youssef Bourouphael <ybourouphael@google.com>
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: mmenke <mmenke@chromium.org>
> > Reviewed-by: mmenke <mmenke@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/main@{#1297048}
>
> Bug: 293383734
> Change-Id: I7ae169c2750432bb1cb9c1c340585dc27d8cd419
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5521778
> Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: mmenke <mmenke@chromium.org>
> Reviewed-by: Orr Bernstein <orrb@google.com>
> Cr-Commit-Position: refs/heads/main@{#1298807}

Bug: 293383734
Change-Id: I182736b58e83dbe7fc2c5fc7e20a3e3f909772a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526425
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
Cr-Commit-Position: refs/heads/main@{#1298902}
  • Loading branch information
HabibiYou authored and chromium-wpt-export-bot committed May 10, 2024
1 parent bbfa8b9 commit d3dfe27
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 175 deletions.
3 changes: 0 additions & 3 deletions fledge/tentative/TODO
Expand Up @@ -96,6 +96,3 @@ If possible:
but maybe a test where batching could be used, and make sure things work,
whether batching is used or not?
* reporting timeout being 0.
* Test that service workers cannot see update urls.
* This was attempted in [here](https://chromium-review.googlesource.com/c/chromium/src/+/5512083),
but needed to be reverted because it kept timing out, [see here](https://g-issues.chromium.org/issues/339048485)
49 changes: 0 additions & 49 deletions fledge/tentative/service-worker-helper.js

This file was deleted.

123 changes: 0 additions & 123 deletions fledge/tentative/service-worker-request-visibility.https.window.js

This file was deleted.

0 comments on commit d3dfe27

Please sign in to comment.