Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on react / react-hook eslinters to ensure consistency with EE #4182

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Turn on react / react-hook eslinters to ensure consistency with EE #4182

wants to merge 15 commits into from

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Dec 28, 2023 •
edited

Closes #3457

Prior to merging this we will need to have remove-req-use-useAsyncFn merged in EE as the removal of useRequestState will break enterprise.

What changed?

As agreed in triage:

  • Introduced react/react-hook rules in eslint config to match EE's eslint config

  • Deactivated:

  1. prop-types
  2. display-name
  • Enforced:
  1. exhaustive-deps
  2. jsx-key
  3. rules-of-hooks
  4. no-children-prop
  5. no-unescaped-entities
  6. no-unknown-property

AlinaGoaga and others added 14 commits December 28, 2023 17:06
@AlinaGoaga
Turn on react / react-hook eslinters
e00aa71
@AlinaGoaga
Turn off react prop types and display names rules
34b9469
@AlinaGoaga
Fix react/jsx-key warnings
382913b
@AlinaGoaga
Fix react/no-children-prop warnings
5d46841
@AlinaGoaga
Fix react/no-unescaped-entities warnings
a67fc73
@AlinaGoaga
Merge branch 'main' into turn-on-react-hook-eslinters
c6e2b33
@AlinaGoaga
Fix react-hooks/rules-of-hooks warnings - WIP
c1b7748
@dependabot
build(deps): Bump msgpackr from 1.5.5 to 1.10.1
524c2ec 
Bumps [msgpackr](https://github.com/kriszyp/msgpackr) from 1.5.5 to 1.10.1.
- [Release notes](https://github.com/kriszyp/msgpackr/releases)
- [Commits](https://github.com/kriszyp/msgpackr/commits/v1.10.1)

---
updated-dependencies:
- dependency-name: msgpackr
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@AlinaGoaga
Fix react-hooks/rules-of-hooks warnings
4b4489f
@AlinaGoaga
Solve conflicts with main - WIP
161fd81
@AlinaGoaga
Solve conflicts with main
942c86f
@AlinaGoaga
Fix react-hooks/exhaustive-deps warnings - WIP
0f87c52
@AlinaGoaga
Fix react-hooks/exhaustive-deps warnings + remove useRequestState hoo…
daf0f8d 
…k which isnt used
@AlinaGoaga
Remove fill from graph foreignObject as the property doesnt exist on …
cbab75f 
…this type of object
@AlinaGoaga AlinaGoaga changed the title Turn on react hook eslinters Turn on react / react-hook eslinters to ensure consistency with EE Dec 29, 2023
@AlinaGoaga
Merge branch 'dependabot/npm_and_yarn/msgpackr-1.10.1' of github.com:…
1052863 
…weaveworks/weave-gitops into turn-on-react-hook-eslinters
@AlinaGoaga AlinaGoaga marked this pull request as ready for review December 29, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AlinaGoaga