Netlify deployment #4130
Netlify deployment #4130
Conversation
There was a problem hiding this comment.
Looked at the PR but I think I might miss some context to review:
looked to the referenced issue where mentioned
Add a new workflow for documentation deployment for Netlify
but could not understand the expected AC for the workflow. please let me know more about it. For example, is under scope the development or staging?
Also, could you add some info about how validation happened?
There was a problem hiding this comment.
I suppose the only way we can actually test this new workflow is by merging it, as with most other changes in GHA.
@Himangini can you set up deploy previews in Netlify so that we can already see the results here?
| jobs: | ||
| publish-docs: | ||
| name: Publish docs to Netlify | ||
| if: ${{ !github.event.release.prerelease }} |
There was a problem hiding this comment.
Will this work when manually running the workflow?
There was a problem hiding this comment.
yeah, it should work.
| run: | | ||
| git config --global user.email "corporate-it+weaveworks-docs-bot@weave.works" | ||
| git config --global user.name "weaveworks-docs-bot" | ||
| git switch docs-production |
There was a problem hiding this comment.
I suppose the way you imagine hotfixes to the docs to land on the website is to issue PRs against docs-production which is ok in my opinion. That way we can use main as dev branch for the next release. But we need to cleary document this new process.
@makkes the deploy preview is set up. |
Part of #4117
What changed?
Deployment workflow to deploy documentation over Netlify when release happens.
Todo - Test over a production branch
Why was this change made?
See issue
How was this change implemented?
How did you validate the change?
Testing deployment manually with Netlify + deploy previews
Release notes
Todo
Documentation Changes
Todo