Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client deps to use Node v6.9.0 #1959

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Conversation

jpellizzari
Copy link
Contributor

From issue #1947.
@davkal, @foot, @bowenli This PR upgrades some dependencies to work with Node 6 LTS. The major change is that jest auto-mocking is turned off by default now. Webpack dev server should be more efficient, and builds should be a little faster. I gathered some data on how long docker image builds are taking before/after:
time docker build -t node4-build . : real 16m12.900s& real 8m39.124s
time docker build -t node6-build .: real 4m13.992s <-- This PR

@davkal
Copy link
Contributor

davkal commented Oct 28, 2016

Yup, great time improvements. LGTM

Also, I tried the node6 presets for babel, as opposed to the currently used ES2015 presets, but I'm getting syntax errors in webpack's uglify step.

@jpellizzari jpellizzari merged commit 0d8152f into master Oct 28, 2016
@jpellizzari
Copy link
Contributor Author

I would imagine that's because Uglify wants ES5 and babel is only transforming stuff that Node 6 doesn't have. The only thing that will get transformed is the ES6 module syntax with the node6 preset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants