Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade client dev runtime to Node 6 LTS #1947

Closed
jpellizzari opened this issue Oct 24, 2016 · 1 comment
Closed

Upgrade client dev runtime to Node 6 LTS #1947

jpellizzari opened this issue Oct 24, 2016 · 1 comment
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@jpellizzari
Copy link
Contributor

jpellizzari commented Oct 24, 2016

Currently, running the webpack dev server and express proxy is eating up a ton of CPU cycles, even when the build isn't running. Upgrading to Node 6 appears to have fixed the problem. This change does break jest tests, however, because the jest-cli package uses an unsupported path argument:

jestjs/jest#1088

Upgradingjest-cli should fix this, but there were breaking changes which will need to be resolved.

Also Node 6.9.1 just went into LTS, so it should be supported until Spring 2018.
https://nodejs.org/en/blog/release/v6.9.0/

@jpellizzari jpellizzari added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Oct 24, 2016
@jpellizzari jpellizzari self-assigned this Oct 24, 2016
@jpellizzari
Copy link
Contributor Author

jpellizzari commented Oct 27, 2016

Test builds:
time docker build -t node4-build . : real 16m12.900s& real 8m39.124s
time docker build -t node6-build .: real 4m13.992s
time docker build -t node4-build . (npm i --production): real 2m51.585s
time docker build -t node6-build . (npm i --production): real 1m43.083s
time docker build -t node6-yarn-build . (yarn --production): real 3m36.824s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

1 participant