This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Assign a random MAC address to the bridge #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
requested review from
chanwit,
darkowlzz,
luxas,
stealthybox and
twelho
as code owners
bboreham
force-pushed
the
bridge-set-mac
branch
from
27cf70f
to
1995743
Compare
If we don't do this it will adopt the lowest address of an attached device, hence change over time. Remove the previous work-around of getting and setting the random MAC that Linux assigned, also getting and setting the TUN address since that doesn't change if you set the bridge address.
Otherwise it just says something like 'invalid argument' and you have to guess what the problem is
bboreham
force-pushed
the
bridge-set-mac
branch
from
1995743
to
0b3815e
Compare
stealthybox
added
area/networking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Did this because I was trying to use an IPVLan device and it barfs if you try to set its MAC address]
If we don't do this it will adopt the lowest address of an attached device, hence change over time. This is the issue reported at #633.
Remove the previous work-around (from #638) of getting and setting the random MAC that Linux assigned, also getting and setting the TUN address since that doesn't change if you set the bridge address.
While I was working on this, I found it useful to add context to some netlink errors.