This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add OCI tool choice #571
Open
Add OCI tool choice #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Begley Brothers Inc <begleybrothers@gmail.com>
stealthybox
reviewed
Apr 10, 2020
| if ! [ -x "$(command -v podman)" ]; then | ||
| oci_tool=podman | ||
| else | ||
| oci_tool=docker |
There was a problem hiding this comment.
Thanks for the patch 👋
Would DOCKER=podman make build be sufficient for you?
This would be consistent with the main Makefile we already have.
Other usage would be:
DOCKER="sudo docker" make build
The kernel build helper scripts would also need to be modified to use this ENV var to override docker.
We could do a followup PR if you don't have the bandwidth to do so.
There was a problem hiding this comment.
No worries: DOCKER=podman. Will try get to that this week and force update this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only alters kernel build scripts.
Preserves existing behavior.
Defaults to
dockerwhenpodmanis not available.Tested as working via
makeSigned-off-by: Begley Brothers Inc begleybrothers@gmail.com