Support docker machine #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic of the initialisation is fairly complex but is documented in `?docker_machine_init`. This works with the situation of >1 machine, but falls back on the same behaviour as the previous `$(boot2docker shellinit)` in the case of a single machine. Because the docker-machine commands can be fairly slow, I've shifted them to be conditional during .onLoad, based on the `harbor.autoconnect` option (which can be set to `TRUE` or a machine name).
This is useful for containers that expose ports, so that the correct IP can be given.
|
I haven't been following changes to boot2docker and Docker Machine recently. Am I right that this will break harbor for people that still just have boot2docker? If that's the case, then at least there should be some sort of message about it. |
|
Given the hanging env problem (e.g., docker/machine#1500), should we require a newer RC version of docker-machine? v0.5.0-rc3 + fix it for me on OSX . Not clear whether folks on Windows/Linux have the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add basic support for docker machine. boot2docker has been deprecated in favour of docker-machine on OS/X and Windows.
I've been using this in another context for a little while and it seems to work fairly well. There is the additional complication that docker machine can support multiple docker servers, and there is a bit of extra logic (documented in b9217d6) that tries to do the right thing here.
There is an issue where copy/paste does not work as expected while system commands to
docker-machineare run.Change of behaviour copied from b9217d6's message:
Happy to revert to the old behaviour if you'd rather, though it triggers at installation which seems problematic.