Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSL connections to gearmand (Issue #43) #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

esabol
Copy link

@esabol esabol commented Nov 19, 2019

This addresses issue #43. It relies on a version of libgearman.so that supports the setSSL() API, which is not yet part of any gearmand release. Refer to gearman/gearmand#63 for details on that issue. These changes are based on chjgcn@gmail.com's patch for some old version of PHP. I heavily modified the code to work with PHP 7.x.

These changes probably need #ifdef HAVE_LIBGEARMAN_SETSSL (or something like that) around them in order to support libgearman.so's that have setSSL() and those that do not.

I've never actually tested it with a PHP SSL worker. We only use PHP SSL on the client side here....

@wcgallego
Copy link
Owner

I'm reluctant to test this if it's not on both server and client side.

I'm several years now out from working directly with either Gearman or PHP, so I'm unable to maintain this going forward. Happy to pass the torch over to another maintainer so it's not held under a personal account of someone who isn't working actively with it

@esabol
Copy link
Author

esabol commented Feb 7, 2020

I'm reluctant to test this if it's not on both server and client side.

No part of the support for setSSL() is "server-side". It is part of libgearman.so, which is a library used by Gearman clients and is not used by the gearmand server. I'm assuming you mean "included in a gearmand release". There's a PR for that. It's been reviewed positively, but not yet merged. I'm hopeful that it will be included in the next gearmand release and that a new release is coming soon. That's the plan.

I'm several years now out from working directly with either Gearman or PHP, so I'm unable to maintain this going forward. Happy to pass the torch over to another maintainer so it's not held under a personal account of someone who isn't working actively with it

That's unfortunate, since, AFAIK, this repo is the only working version of this extension for PHP 7+. I hope someone who cares about PHP Gearman will fork and take up the torch. In the meantime, please leave this PR open for others to find.

@esabol
Copy link
Author

esabol commented Feb 11, 2020

Gearmand 1.1.19 was just released today with support for the setSSL() API!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants