Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group name changed to group ID on Windows #579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rewerson
Copy link

On non-English Windows hosts there is no 'Administrators' group. For example, in russian version, it's called 'Администраторы'.
In manifests it's more reliable to use ID of this privileged group.
This ID is constant across Windows with any languages.

@gdeleon23
Copy link

Hi Rewerson,

If i try your pull in Spanish Windows 2022 es working ok, but, i try the same in Ubuntu and now i have this error:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Module wazuh is not supported on Ubuntu (file: /etc/puppetlabs/code/environments/xxx/modules/wazuh/manifests/params_agent.pp, line: 335, column: 15) on node xxx

With the master branch, in Ubuntu is working ok, but in Spanish Windows 2022 i have the same error with Administrators group.

I clone the branch (4.5), and i did exactly the sames changes you did in your pull request. And now is working ok in Windows Spanish and Ubuntu. Can you change it in your pull request and try again?

Thank you.

@Rewerson
Copy link
Author

Hi @gdeleon23
Updated my fork and this PR, which becames older and older. Sadly, year without maintainer approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants