Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard package version #560

Open
wants to merge 1 commit into
base: 4.3
Choose a base branch
from
Open

Fix dashboard package version #560

wants to merge 1 commit into from

Conversation

poloz-lab
Copy link
Contributor

This PR fixes #530.

Tested with Puppet 6.27.0 on a Debian 10 machine.

@cruelsmith
Copy link
Contributor

LGTM
It also ensure that the versioning inside the puppet module is consistent again. All versions are now specific package versions.

Side notes:

On Debian systems the apt::pin with a wildcard usage in version like 4.3.7-* could be also used as alternative to achieve this.
Sadly on RHEL with yum / dnf plugin versionlock this does not work because they need a full package versions that allow wildcards only for the arch 0:4.3.7-1.* else they will fully block the installation, update or remove of that package in any version.

That said the wanted better version managing can only be archived via separated repositories on patch level so that the package ensure can be set to latest or installed when no auto update is wanted like https://packages.wazuh.com/4.3.7/yum/ instead of currently https://packages.wazuh.com/4.x/yum/. This would also fix the problem that a system update will upgrade the wazuh package to the latest version inside the repo.

@poloz-lab poloz-lab force-pushed the fix-530-dashboard-package-version branch 2 times, most recently from 021624d to 187182b Compare September 15, 2022 08:10
@poloz-lab poloz-lab force-pushed the fix-530-dashboard-package-version branch from 187182b to 5c9e3f9 Compare September 29, 2022 09:20
@poloz-lab poloz-lab force-pushed the fix-530-dashboard-package-version branch from 5c9e3f9 to e7429b6 Compare December 21, 2022 14:02
@poloz-lab
Revert "split package version for OS family"
e63bb87 
This reverts commits:
-d56f7dfb01b0dd0954f30c1e8f322146dc5e7b37
-15e50806a5971fe4c2b870d0442127214547b91e
@poloz-lab poloz-lab force-pushed the fix-530-dashboard-package-version branch from e7429b6 to e63bb87 Compare February 10, 2023 08:14
@le-ya le-ya mentioned this pull request Aug 2, 2023
Merged
@poloz-lab
Copy link
Contributor Author

Hi,

I want to update the PR, but I don't know on which branch the PR should be based on.

Is it 4.8.0 , 4.8.1 , 4.8.2 or 4.9.0 or something else ?

@poloz-lab poloz-lab mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruelsmith cruelsmith cruelsmith approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poloz-lab @cruelsmith