Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Azure module files #2698

Merged
merged 1 commit into from May 16, 2024

Conversation

nico-stefani
Copy link
Member

@nico-stefani nico-stefani commented Dec 18, 2023

Related issue
#2689

Description

Closes #2689. It modifies the Solaris11 SPEC file to include in the agents the latest modification of the Azure integration which separated the module in several files carried out in wazuh/wazuh#19576, which is expected to be released in 4.9.0.

Logs example

Tests

Tested the modified package by creating a Solaris11 package and installing it in a Solaris11 machine respectively. Everything worked as expected, as can be seen in the following output:

Package installation and file permissions

root@solaris11:~# pkg install -g wazuh-agent_v4.9.0-2689.azure.refactor.v2-sol11-i386.p5p  wazuh-agent
           Packages to install:  1
            Services to change:  1
       Create boot environment: No
Create backup boot environment: No

DOWNLOAD                                PKGS         FILES    XFER (MB)   SPEED
Completed                                1/1       126/126      6.0/6.0 33.0M/s

PHASE                                          ITEMS
Installing new actions                       184/184
Updating package state database                 Done
Updating package cache                           0/0
Updating image state                            Done
Creating fast lookup database                   Done
Reading search index                            Done
Updating search index                            1/1
Updating package cache                           2/2
root@solaris11:~# tree /var/ossec/wodles/azure/ -L 2 -u -g
/var/ossec/wodles/azure/
├── [root     wazuh   ]  azure_services
│   ├── [root     wazuh   ]  __init__.py
│   ├── [root     wazuh   ]  analytics.py
│   ├── [root     wazuh   ]  graph.py
│   └── [root     wazuh   ]  storage.py
├── [root     wazuh   ]  azure_utils.py
├── [root     wazuh   ]  azure-logs
└── [root     wazuh   ]  db
    ├── [root     wazuh   ]  __init__.py
    ├── [root     wazuh   ]  orm.py
    └── [root     wazuh   ]  utils.py

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md
  • Tests for Linux RPM
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • %files section is correctly updated if necessary
  • Tests for Linux deb
    • Build the package for x86_64
    • Build the package for i386
    • Build the package for armhf
    • Build the package for aarch64
    • Package install/remove/install
    • Package install/purge/install
    • Check file permissions after installing the package
  • Tests for macOS
    • Test the package from macOS Sierra to Mojave
  • Tests for Solaris
    • Test the package on Solaris 10
    • Test the package on Solaris 11
    • Check file permissions on Solaris 11 template
  • Tests for IBM AIX
    • %files section is correctly updated if necessary
    • Check the changes from IBM AIX 5 to 7

@nico-stefani nico-stefani self-assigned this Dec 18, 2023
Copy link

@EduLeon12 EduLeon12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Selutario
Selutario previously approved these changes Jan 25, 2024
Copy link
Member

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Moving this to blocked so we merge it all together.

@nico-stefani nico-stefani changed the base branch from master to 4.9.0 May 9, 2024 16:04
@nico-stefani nico-stefani dismissed Selutario’s stale review May 9, 2024 16:04

The base branch was changed.

@nico-stefani nico-stefani force-pushed the enhancement/2689-add-azure-refactored-files branch from 0a2fa5a to 8b93af7 Compare May 9, 2024 16:13
Signed-off-by: Nico Stefani <nicolas.stefi@wazuh.com>
@nico-stefani nico-stefani force-pushed the enhancement/2689-add-azure-refactored-files branch from 8b93af7 to bc86f34 Compare May 9, 2024 16:19
@Selutario Selutario merged commit 69c4398 into 4.9.0 May 16, 2024
4 checks passed
@Selutario Selutario deleted the enhancement/2689-add-azure-refactored-files branch May 16, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review package related files due to Azure module refactor
4 participants