Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename indexer configuration nodes #1981

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

DFolchA
Copy link
Contributor

@DFolchA DFolchA commented Dec 13, 2022

Related issue
#1974

Description

This PR changes the node names for indexer in the default config.yml template for the documentation and the indexer default configuration.

Related issue: wazuh/wazuh-documentation#5793

Logs example

Tests

  • Build the package in any supported platform
    • Linux
    • Windows
    • macOS
    • Solaris
    • AIX
    • HP-UX
  • Package installation
  • Package upgrade
  • Package downgrade
  • Package remove
  • Package install/remove/install
  • Change added to CHANGELOG.md

@DFolchA DFolchA self-assigned this Dec 13, 2022
#- "node-3"
- "indexer-1"
#- "indexer-2"
#- "indexer-3"
cluster.name: "wazuh-cluster"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wazuh-indexer-cluster would be a less confusing name

@@ -1,7 +1,7 @@
network.host: "127.0.0.1"
node.name: "node-1"
node.name: "indexer-1"
cluster.initial_master_nodes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

- name: wazuh-1
ip: <wazuh-manager-ip>
- name: server-1
ip: "<wazuh-manager-ip>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ip: "<wazuh-manager-ip>"
ip: "<wazuh-server-ip>"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should also be applied to server-2 and server-3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 504383b

#- name: wazuh-2
# ip: <wazuh-manager-ip>
#- name: server-2
# ip: "<wazuh-manager-ip>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the variables are not numbered? i.e <wazuh-server-2-ip>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 504383b

Copy link
Contributor

@verdx verdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DFolchA DFolchA changed the base branch from 4.4 to master January 10, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants