Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coredump generation config on Windows endpoints #7299

Merged
merged 4 commits into from May 13, 2024
Merged

Coredump generation config on Windows endpoints #7299

merged 4 commits into from May 13, 2024

Conversation

tdrauncieal
Copy link

@tdrauncieal tdrauncieal commented May 9, 2024 •
edited

Related Issue
#7287

Description

This pull request aims to conclude the development exposed in the related issue, adding documentation of the process and steps to enable/disable coredump generation to be made on Windows O.S.

Build output log

[sphinx-autobuild] > sphinx-build /home/python/docs /home/python/build/html
Running Sphinx v7.0.1
loading translations [en-US]... not available for built-in messages
building [mo]: targets for 0 po files that are out of date                                                                                                                                                         
writing output...                                                                                                                                                                                                  
building [html]: targets for 705 source files that are out of date                                                                                                                                                 
updating environment: [new config] 705 added, 0 changed, 0 removed                                                                                                                                                
reading sources... [100%] user-manual/wazuh-indexer/wazuh-indexer-tuning                                                                                                                                         
Copying static files for wazuh-doc-images...[100%] img/loading.gif                                                                                                                                                 
looking for now-outdated files... none found                                                                                                                                                                       
pickling environment... done                                                                                                                                                                                       
checking consistency... done                                                                                                                                                                                       
preparing documents... done                                                                                                                                                                                        
writing output... [100%] user-manual/wazuh-indexer/wazuh-indexer-tuning                                                                                                                                            
generating indices... done                                                                                                                                                                                         
writing additional pages... not_found moved-content search done                                                                                                                                                    
copying images... [100%] images/manual/wazuh-indexer/indexer-cluster-with-shard-replicas-diagram.png                                                                                                               
copying static files... done                                                                                                                                                                                       
copying extra files... done                                                                                                                                                                                        
dumping search index in English (code: en)... done                                                                                                                                                                 
dumping object inventory... done                                                                                                                                                                                   
build succeeded.

Output

image

Docs building

  • Compiles without warnings.

@tdrauncieal tdrauncieal requested review from javimed and removed request for javimed May 9, 2024 19:45
@tdrauncieal tdrauncieal changed the base branch from master to 4.9.0 May 9, 2024 19:45
@tdrauncieal tdrauncieal changed the title 7287 coredump setup howto Coredump generation config on Windows endpoints May 9, 2024
@tdrauncieal tdrauncieal linked an issue May 9, 2024 that may be closed by this pull request
Config of Core Dump generation on Windows OS of wazuh agents (HOWTO) #7287
Closed
2 tasks
@tdrauncieal tdrauncieal self-assigned this May 10, 2024
@tdrauncieal tdrauncieal marked this pull request as ready for review May 10, 2024 13:24
Leoquicenoz
Leoquicenoz previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Leoquicenoz Leoquicenoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

aritosteles
aritosteles requested changes May 10, 2024
View reviewed changes
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
aritosteles
aritosteles previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@aritosteles aritosteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Leoquicenoz
Leoquicenoz previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Leoquicenoz Leoquicenoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ncvicchi
ncvicchi previously approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@ncvicchi ncvicchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels May 10, 2024
javimed
javimed requested changes May 13, 2024
View reviewed changes
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
source/development/coredump.rst Outdated Show resolved Hide resolved
@tdrauncieal @javimed
Apply suggestions from code review
7571d98 
Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
aritosteles
aritosteles approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@aritosteles aritosteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javimed javimed merged commit e7420e2 into 4.9.0 May 13, 2024
3 checks passed
@javimed javimed deleted the 7287-coredump-setup-howto branch May 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javimed javimed javimed approved these changes

@aritosteles aritosteles aritosteles approved these changes

@ncvicchi ncvicchi Awaiting requested review from ncvicchi

@Leoquicenoz Leoquicenoz Awaiting requested review from Leoquicenoz

Assignees

@tdrauncieal tdrauncieal

Labels
level/task Task issue type/enhancement Enhancement issue
Projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config of Core Dump generation on Windows OS of wazuh agents (HOWTO)
5 participants
@tdrauncieal @javimed @ncvicchi @aritosteles @Leoquicenoz