Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnerabilities dashboard custom KPIs labels #6559

Merged
merged 2 commits into from Apr 3, 2024
Merged

Fix vulnerabilities dashboard custom KPIs labels #6559

merged 2 commits into from Apr 3, 2024

Conversation

asteriscos
Copy link
Member

Description

This pull request fixes the vulnerabilities KPI's custom labels so they properly add the filter label when the user clicks them

Issues Resolved

Parent issue:

Evidence

Peek 2024-03-27 14-36

Test

  • Go to Vulnerabilities dashboard
  • Check the KPI's label are Critical - Severity High - Severity Medium - Severity Low - Severity
  • Click on the KPI's and check they add the custom label filter with the severity value

Check List

  • All tests pass
    • yarn test:jest
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 27, 2024
@asteriscos asteriscos linked an issue Mar 27, 2024 that may be closed by this pull request
Refine vulnerabilities dashboard #6533
Closed
6 tasks
@yenienserrano yenienserrano self-requested a review April 3, 2024 13:09
@jbiset jbiset self-requested a review April 3, 2024 13:32
jbiset
jbiset approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI: 🟢

Evidence

evidence.webm

yenienserrano
yenienserrano approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Details
Grabacion.de.pantalla.2024-04-03.a.las.11.30.55.a.m.mov

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.85% ( 186 / 892 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.05% ( 183 / 869 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4213 / 34717 )
Branches 8.2% ( 1910 / 23270 )
Functions 11.57% ( 958 / 8275 )
Lines 12.3% ( 4101 / 33319 )

@asteriscos asteriscos merged commit 6ffebc1 into 4.8.0 Apr 3, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/refine-vulnerabilities-dashboard-6533 branch April 3, 2024 17:09
@asteriscos asteriscos mentioned this pull request Apr 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine vulnerabilities dashboard
3 participants
@asteriscos @jbiset @yenienserrano