Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the reporting to the rendering of dashboards #6558

Draft
wants to merge 9 commits into
base: 4.9.0
Choose a base branch
from

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Mar 27, 2024

Description

This pull request adapts the reporting to the rendering of dashboards.

Changes:

  • Adapt the Generate report button to use the search context
    • Create state and reducers into Redux store
    • Create hook to send the search context from a dashboard
      to the Generate report button
    • Remove disabledReport property and use the search context instead
    • Replace the mechanim to take the visualizations of the screenshots from the DOM
    • Remove the dependency injection of the unused AngularJS service to
      generate the reports
  • Add abilities to the toast message when a PDF report is generated:
    • Open the report
    • Go to the Reporting application
  • Remove unused AngularJS service to generate the reports

Warning

This pull request depends on the implementations of dashboards #6477.

Issues Resolved

#6556

Evidence

Report toast
image

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

- Adapt the Generate report button to use the search context
  - Create state and reducers into Redux store
  - Create hook to send the search context from a dashboard
    to the Generate report button
  - Remove disabledReport property and use the search context instead
- Replace the mechanim to take the visualizations of the screenshots from the DOM
- Remove the dependency injectiong of the unused AngularJS service to
  generate the reports
…rated

- Add abilities to the toast message when a PDF report is generated:
  - Open the report
  - Go to Reporting application
@Desvelao Desvelao self-assigned this Mar 27, 2024
@Desvelao Desvelao linked an issue Mar 27, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 28.94% ( 286 / 988 )
Branches 26.22% ( 107 / 408 )
Functions 26.87% ( 86 / 320 )
Lines 28.68% ( 278 / 969 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.15% ( 4212 / 34661 )
Branches 7.8% ( 1776 / 22750 )
Functions 10.76% ( 888 / 8249 )
Lines 12.34% ( 4101 / 33222 )

@Desvelao Desvelao changed the title Adapt the reporting to the redering of dashboards Adapt the reporting to the rendering of dashboards Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement new PDF reports in dashboards
1 participant