Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine malware detection dashboard #6554

Merged
merged 3 commits into from Mar 27, 2024
Merged

Refine malware detection dashboard #6554

merged 3 commits into from Mar 27, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 26, 2024 •
edited

Description

This pull request changes the top left visualization label from Emotet malware activity to Malware activity and removes the fields rule.mitre.tactic and rule.mitre.id in the lower table.
It also adds an enhancement with custom widths for columns with a known short data length: Time; Rule level; Rule ID; Count

Issues Resolved

Closes #6552

Evidence

screencapture-localhost-5601-app-malware-detection-2024-03-26-14_45_59

Test

  • Go to Malware detection
  • Check the top left visualization label says "Malware activity"
  • Check the bottom table doesn't have any rule.mitre field

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 26, 2024
Desvelao
Desvelao approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@asteriscos asteriscos linked an issue Mar 26, 2024 that may be closed by this pull request
Refine Malware detection dashboard #6552
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

@JuanGarriuz
Copy link
Member

Test

Evidence

image
image

JuanGarriuz
JuanGarriuz approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit ff3b453 into 4.8.0 Mar 27, 2024
4 checks passed
@asteriscos asteriscos deleted the change/refine-malware-detection-dashboard-6552 branch March 27, 2024 09:26
@asteriscos asteriscos mentioned this pull request Apr 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine Malware detection dashboard
3 participants
@asteriscos @JuanGarriuz @Desvelao