Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS log collector tab #6545

Merged
merged 3 commits into from Mar 27, 2024
Merged

Add macOS log collector tab #6545

merged 3 commits into from Mar 27, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 21, 2024 •
edited

Description

This PR adds macOS log collector tab.

Issues Resolved

Closes #6389

Evidence

image

Test

  • Install a macOS agent
  • Configured log collector - Documentation
  • Go to Endpoints Summary
  • Select the macOS agent
  • Go to Configuration / Log collection
  • Check the macOS tabs exists and the configuration is correct
    image

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 21, 2024
@asteriscos asteriscos linked an issue Mar 21, 2024 that may be closed by this pull request
Wazuh web interface to display agent "log collector" configuration details, skips the use of the "macos" logformat #6389
Closed
@asteriscos asteriscos marked this pull request as ready for review March 22, 2024 12:24
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 28.94% ( 286 / 988 )
Branches 26.22% ( 107 / 408 )
Functions 26.87% ( 86 / 320 )
Lines 28.68% ( 278 / 969 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.12% ( 4210 / 34729 )
Branches 7.8% ( 1776 / 22760 )
Functions 10.77% ( 888 / 8244 )
Lines 12.31% ( 4099 / 33289 )

@Desvelao
Copy link
Member

Test

image
image

Desvelao
Desvelao approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JuanGarriuz JuanGarriuz self-requested a review March 26, 2024 08:20
@JuanGarriuz
Copy link
Member

JuanGarriuz commented Mar 26, 2024 •
edited

Test

Evidence

image

JuanGarriuz
JuanGarriuz approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@asteriscos asteriscos merged commit 202d43b into 4.9.0 Mar 27, 2024
4 checks passed
@asteriscos asteriscos deleted the enhance/display-logcollector-macos-format-6389 branch March 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asteriscos @Desvelao @JuanGarriuz