Remove tools and dev tools AngularJS controllers #6544

Desvelao · 2024-03-21T10:13:41Z

Description

This pull request removes the tools and dev tools AngularJS controllers.

Changes:

Remove dev tools and tools controllers
Replace the render using an AngularJS template by a ReactJS component
Create ToolsRouter component to manage the routing of Dev Tools and
Ruleset Test views
Move logic and render of dev tools to a ReactJS component
Remove unused definitions of controllers and variables in AngularJS

Issues Resolved

#6539

Evidence

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Go to Server management > Dev Tools and the application should be visible	⚫	⚫	⚫
In Server management > Dev Tools, test the API endpoint suggestions are working as previously	⚫	⚫	⚫
In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side	⚫	⚫	⚫
In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side	⚫	⚫	⚫
In Server management > Dev Tools, click on the link to get information about the API referene that is located in the top right corner	⚫	⚫	⚫
In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported	⚫	⚫	⚫
Go to Server management > Dev Tools and the breadcrumb should display the name of the application	⚫	⚫	⚫
Go to Server management > Ruleset Test and the application should be visible	⚫	⚫	⚫
Go to Server management > Ruleset Test and the breadcrumb should display the name of the application	⚫	⚫	⚫

Details

⚫ Go to Server management > Dev Tools and the application should be visible

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ In Server management > Dev Tools, test the API endpoint suggestions are working as previously

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ In Server management > Dev Tools, click on the link to get information about the API referene that is located in the top right corner

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to Server management > Dev Tools and the breadcrumb should display the name of the application

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to Server management > Ruleset Test and the application should be visible

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to Server management > Ruleset Test and the breadcrumb should display the name of the application

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

- Remove dev tools and tools controllers - Replace the render using an AngularJS template by a ReactJS component - Create ToolsRouter component to manage the routing of Dev Tools and Ruleset Test views - Move logic and render of dev tools to a ReactJS component - Remove unused definitions of controllers and variables in AngularJS

…o feat/6536-remove-angularjs-controller-tools

JuanGarriuz · 2024-04-03T09:12:02Z

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Go to Server management > Dev Tools and the application should be visible	🟢	⚫	⚫
In Server management > Dev Tools, test the API endpoint suggestions are working as previously	🟢	⚫	⚫
In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side	🟢	⚫	⚫
In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side	🟢	⚫	⚫
In Server management > Dev Tools, click on the link to get information about the API referene that is located in the top right corner	🟢	⚫	⚫
In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported	🟢	⚫	⚫
Go to Server management > Dev Tools and the breadcrumb should display the name of the application	🟢	⚫	⚫
Go to Server management > Ruleset Test and the application should be visible	🟢	⚫	⚫
Go to Server management > Ruleset Test and the breadcrumb should display the name of the application	🟢	⚫	⚫

Details

🟢 Go to Server management > Dev Tools and the application should be visible

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 In Server management > Dev Tools, test the API endpoint suggestions are working as previously

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 In Server management > Dev Tools, click on the link to get information about the API reference that is located in the top right corner

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to Server management > Dev Tools and the breadcrumb should display the name of the application

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to Server management > Ruleset Test and the application should be visible

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to Server management > Ruleset Test and the breadcrumb should display the name of the application

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

JuanGarriuz

LGTM!!

yenienserrano · 2024-04-03T16:10:30Z

Test	Chrome	Firefox	Safari
Go to Server management > Dev Tools and the application should be visible	⚫	⚫	🟢
In Server management > Dev Tools, test the API endpoint suggestions are working as previously	⚫	⚫	🟢
In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side	⚫	⚫	🟢
In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side	⚫	⚫	🟡
In Server management > Dev Tools, click on the link to get information about the API referene that is located in the top right corner	⚫	⚫	🟡
In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported	⚫	⚫	🟢
Go to Server management > Dev Tools and the breadcrumb should display the name of the application	⚫	⚫	🟢
Go to Server management > Ruleset Test and the application should be visible	⚫	⚫	🟢
Go to Server management > Ruleset Test and the breadcrumb should display the name of the application	⚫	⚫	🟢

Details

🟢 Go to Server management > Dev Tools and the application should be visible

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

🟢 In Server management > Dev Tools, test the API endpoint suggestions are working as previously

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

🟢 In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

🟡 In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side

When I click on the information icons, the text area on the left changes position

Chrome - ⚫

Firefox - ⚫

Safari - 🟡

🟡 In Server management > Dev Tools, click on the link to get information about the API referene that is located in the top right corner

When I click on the information icons, the text area on the left changes position

Chrome - ⚫

Firefox - ⚫

Safari - 🟡

🟢 In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

🟢 Go to Server management > Dev Tools and the breadcrumb should display the name of the application

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

🟢 Go to Server management > Ruleset Test and the application should be visible

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

🟢 Go to Server management > Ruleset Test and the breadcrumb should display the name of the application

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

yenienserrano

CR: ✅
Test: ✅

github-actions · 2024-04-04T08:49:51Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	31.12%	( 286 / 919 )
Branches	29.88%	( 107 / 358 )
Functions	28.1%	( 86 / 306 )
Lines	30.71%	( 278 / 905 )

github-actions · 2024-04-04T08:49:59Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-04-04T08:54:08Z

Main plugin code coverage (Jest) test	%	values
Statements	10.64%	( 3685 / 34601 )
Branches	7.14%	( 1621 / 22699 )
Functions	10.31%	( 849 / 8234 )
Lines	10.79%	( 3581 / 33165 )

Desvelao added 2 commits March 21, 2024 11:10

fix: prettier

70795c5

Desvelao self-assigned this Mar 21, 2024

Merge branch '4.9.0' of https://github.com/wazuh/wazuh-kibana-app int…

c8287db

…o feat/6536-remove-angularjs-controller-tools

Desvelao linked an issue Mar 21, 2024 that may be closed by this pull request

[Remove discover] Refactor AngularJS tools and dev tools controllers #6539

Closed

changelog: add pull request entry

6c3b878

Desvelao marked this pull request as ready for review March 21, 2024 13:04

JuanGarriuz self-requested a review April 2, 2024 11:46

Desvelao and others added 3 commits April 2, 2024 13:48

Merge branch '4.9.0' into feat/6536-remove-angularjs-controller-tools

e4f7ce6

Merge branch '4.9.0' of https://github.com/wazuh/wazuh-kibana-app int…

fdaecf0

…o feat/6536-remove-angularjs-controller-tools

changelog: move and edit entries

9e0f6b9

JuanGarriuz previously approved these changes Apr 3, 2024

View reviewed changes

yenienserrano self-requested a review April 3, 2024 11:32

yenienserrano previously approved these changes Apr 3, 2024

View reviewed changes

Merge branch '4.9.0' into feat/6536-remove-angularjs-controller-tools

ba3f2f4

asteriscos dismissed stale reviews from yenienserrano and JuanGarriuz via ba3f2f4 April 4, 2024 08:47

asteriscos approved these changes Apr 4, 2024

View reviewed changes

asteriscos merged commit ee9894d into 4.9.0 Apr 4, 2024
4 checks passed

asteriscos deleted the feat/6536-remove-angularjs-controller-tools branch April 4, 2024 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove tools and dev tools AngularJS controllers #6544

Remove tools and dev tools AngularJS controllers #6544

Desvelao commented Mar 21, 2024 •

edited

JuanGarriuz commented Apr 3, 2024 •

edited

JuanGarriuz left a comment

yenienserrano commented Apr 3, 2024 •

edited

yenienserrano left a comment

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

Remove tools and dev tools AngularJS controllers #6544

Remove tools and dev tools AngularJS controllers #6544

Conversation

Desvelao commented Mar 21, 2024 • edited

Description

Issues Resolved

Evidence

Test

UI

Check List

JuanGarriuz commented Apr 3, 2024 • edited

Test

UI

JuanGarriuz left a comment

Choose a reason for hiding this comment

yenienserrano commented Apr 3, 2024 • edited

yenienserrano left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

github-actions bot commented Apr 4, 2024

Desvelao commented Mar 21, 2024 •

edited

JuanGarriuz commented Apr 3, 2024 •

edited

yenienserrano commented Apr 3, 2024 •

edited