Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vulnerabilities dashboard #6541

Merged
merged 5 commits into from Mar 26, 2024
Merged

Change vulnerabilities dashboard #6541

merged 5 commits into from Mar 26, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 20, 2024 •
edited

Description

This pull request makes additional changes to the Vulnerabilities dashboard as part of another refinement iteration.

Issues Resolved

Closes #6533

Evidence

image

Test

  • The severity KPIs must be placed in the first row of the dashboard
  • The filter tables must be placed in the second row of the dashboard
  • The filter tables order must be: Top 5 vulnerabilities, Top 5 OS, Top 5 agents, Top 5 packages
  • The Top 5 OS, Top 5 agents tables must be wider than the Top 5 vulnerabilities, Top 5 packages tables
  • We have to remove the word alerts and hyphens from the KPIs
  • We must change the @timestamp field used in the Accumulation of the most detected vulnerabilities visualization for the new field published_at

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 20, 2024
@asteriscos asteriscos linked an issue Mar 20, 2024 that may be closed by this pull request
Refine vulnerabilities dashboard #6533
Closed
6 tasks
@lucianogorza
Copy link
Member

lucianogorza commented Mar 21, 2024 •
edited

CR 🟢

Test 🟢

image

lucianogorza
lucianogorza previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desvelao
Copy link
Member

Test 🟢

image

Desvelao
Desvelao previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos dismissed stale reviews from Desvelao and lucianogorza via 175270a March 25, 2024 18:48
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

@Desvelao
Copy link
Member

LGTM!

image

Desvelao
Desvelao approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit 38c32fd into 4.8.0 Mar 26, 2024
4 checks passed
@asteriscos asteriscos deleted the change/refine-vulnerabilities-dashboard-6533 branch March 26, 2024 18:01
@asteriscos asteriscos mentioned this pull request Apr 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@lucianogorza lucianogorza lucianogorza left review comments

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine vulnerabilities dashboard
3 participants
@asteriscos @lucianogorza @Desvelao