Remove AngularJS controller of blank screen #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove AngularJS controller of blank screen view - Remove usage of controller in the html template - Move logic to manage the error message to the BlankScreen component
TestEvidence
|
JuanGarriuz
previously approved these changes
Apr 2, 2024
…o feat/6536-remove-angularjs-controller-blank-screen
JuanGarriuz
previously approved these changes
Apr 3, 2024
asteriscos
requested changes
Apr 3, 2024
plugins/main/public/components/wz-blank-screen/wz-blank-screen.js
Outdated
Show resolved
Hide resolved
plugins/main/public/components/wz-blank-screen/wz-blank-screen.js
Outdated
Show resolved
Hide resolved
|
|
|
@asteriscos, I was researching about the repeated mounts of the Blank Screen component but I did not find the cause. If we consider it, we could need a deep analysis with more time. |
|
asteriscos
approved these changes
Apr 4, 2024
asteriscos
deleted the
feat/6536-remove-angularjs-controller-blank-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the AngularJS controller of blank screen.
Changes:
navigateToAppmethod exposed by the platform core pluginIssues Resolved
#6536
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Force a blank screen error (see source code) and the error should be displayed in the UI.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest