Add filter for outdated agents #6529

lucianogorza · 2024-03-18T15:34:05Z

Description

Add a quick filter to the agent's table so that the user can list only the outdated agents.
Improve the way filtering works when clicking on the Outdated agents alert.

Issues Resolved

#6512

Evidence

outdated-filter.webm

Test

Test with 4.9.0 manager
Test with up to date and outdated agents

Command to create an outdated agent with docker:

docker run --name os-dev-2120-agent-$(date +%s) --network os-dev-2.12.0 --label com.docker.compose.project=os-dev-2120 --env WAZUH_AGENT_VERSION=4.6.0 -d ubuntu:20.04 bash -c '
  apt update -y
  apt install -y curl lsb-release
  curl -so \wazuh-agent-${WAZUH_AGENT_VERSION}.deb \
    https://packages.wazuh.com/4.x/apt/pool/main/w/wazuh-agent/wazuh-agent_${WAZUH_AGENT_VERSION}-1_amd64.deb \
    && WAZUH_MANAGER='wazuh.manager' WAZUH_AGENT_GROUP='default' dpkg -i ./wazuh-agent-${WAZUH_AGENT_VERSION}.deb

  /etc/init.d/wazuh-agent start
  tail -f /var/ossec/logs/ossec.log
'

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test	Chrome	Firefox	Safari
With no outdated agents: Alert must show 0	⚫	⚫	⚫
With no outdated agents: `Show only outdated` filter must be off and disabled	⚫	⚫	⚫
With at least one outdated agent: Alert must show the total outdated agents	⚫	⚫	⚫
With at least one outdated agent: `Show only outdated` filter must be off and enabled	⚫	⚫	⚫
With at least one outdated agent: Click on alert and filter by outdated agents	⚫	⚫	⚫
With at least one outdated agent: Click on `Show only outdated` filter to turn on and turn off	⚫	⚫	⚫

Details

⚫ With no outdated agents: Alert must show 0

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With no outdated agents: `Show only outdated` filter must be off and disabled

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With at least one outdated agent: Alert must show the total outdated agents

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With at least one outdated agent: `Show only outdated` filter must be off and enabled

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With at least one outdated agent: Click on alert and filter by outdated agents

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With at least one outdated agent: Click on `Show only outdated` filter to turn on and turn off

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…ents

asteriscos · 2024-03-21T17:35:38Z

Tests worked OK, but I found this strange behavior. The Upgrade task details and Upgrade agents is duplicated.

Test	Chrome	Firefox	Safari
With no outdated agents: Alert must show 0	🟢	⚫	⚫
With no outdated agents: `Show only outdated` filter must be off and disabled	🟢	⚫	⚫
With at least one outdated agent: Alert must show the total outdated agents	🟢	⚫	⚫
With at least one outdated agent: `Show only outdated` filter must be off and enabled	🟢	⚫	⚫
With at least one outdated agent: Click on alert and filter by outdated agents	🟢	⚫	⚫
With at least one outdated agent: Click on `Show only outdated` filter to turn on and turn off	🟢	⚫	⚫

Details

🟢 With no outdated agents: Alert must show 0

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With no outdated agents: `Show only outdated` filter must be off and disabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: Alert must show the total outdated agents

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: `Show only outdated` filter must be off and enabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: Click on alert and filter by outdated agents

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: Click on `Show only outdated` filter to turn on and turn off

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

asteriscos

See the last comment.

asteriscos

CR: ✔️
Test: ✔️

plugins/main/public/components/endpoints-summary/table/agents-table.test.tsx

plugins/main/public/components/endpoints-summary/table/agents-table.tsx

JuanGarriuz · 2024-03-22T11:29:05Z

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test	Chrome	Firefox	Safari
With no outdated agents: Alert must show 0	🟢	⚫	⚫
With no outdated agents: `Show only outdated` filter must be off and disabled	🟢	⚫	⚫
With at least one outdated agent: Alert must show the total outdated agents	🟢	⚫	⚫
With at least one outdated agent: `Show only outdated` filter must be off and enabled	🟢	⚫	⚫
With at least one outdated agent: Click on alert and filter by outdated agents	🟢	⚫	⚫
With at least one outdated agent: Click on `Show only outdated` filter to turn on and turn off	🟢	⚫	⚫

Details

🟢 With no outdated agents: Alert must show 0

Chrome - 🟢:

Firefox - ⚫

Safari - ⚫

🟢 With no outdated agents: `Show only outdated` filter must be off and disabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: Alert must show the total outdated agents

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: `Show only outdated` filter must be off and enabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: Click on alert and filter by outdated agents

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 With at least one outdated agent: Click on `Show only outdated` filter to turn on and turn off

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

JuanGarriuz

LGTM!!

Desvelao · 2024-03-22T12:43:48Z

ssugestion: as generic reference, when something is disabled in the UI, adding the cause could enhance the user experience.

The Show only updated switch is disabled, but I don't know the reason, I think adding it could be useful to the user.

lucianogorza · 2024-03-22T14:30:31Z

Update 22/03/2024

Add tooltip when there are no outdated agents

github-actions · 2024-03-22T15:42:45Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	28.94%	( 286 / 988 )
Branches	26.22%	( 107 / 408 )
Functions	26.87%	( 86 / 320 )
Lines	28.68%	( 278 / 969 )

github-actions · 2024-03-22T15:43:02Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-03-22T15:47:30Z

Main plugin code coverage (Jest) test	%	values
Statements	12.08%	( 4203 / 34786 )
Branches	7.79%	( 1774 / 22762 )
Functions	10.74%	( 887 / 8258 )
Lines	12.27%	( 4092 / 33345 )

Desvelao

LGTM!

code review 🟢
request changes 🟢

lucianogorza added 17 commits March 15, 2024 11:53

Add upgrade agents global action

dbfffb5

Add Upgrade result modal

23d9bba

Update CHANGELOG

ada67c2

Minor fixes

adbadbe

Add unit tests

1b13ab9

Improve upgrade progress message

07e822c

Remove wazuh-endpoints plugin

5211603

Fix file name

8fcaa4f

Fix import

562c16b

Fix get tasks status for readonly user

9f505c9

Improve return condition

6c40834

Improve error message for Timeout status

b2f0275

Add tooltipo to timeout status

10f17f3

Modularize get status functions

01e8307

Fix status name and key values

1afefd1

Separate upgrade service in two services

e1ddf49

Add filter for outdated agents

f46f0da

lucianogorza self-assigned this Mar 18, 2024

lucianogorza linked an issue Mar 18, 2024 that may be closed by this pull request

Add filter for outdated agents #6512

Closed

2 tasks

lucianogorza added 11 commits March 18, 2024 12:49

Update CHANGELOG

e7ddd15

Update unit tests

9902222

Update agents-table unit tests

0d8baf9

Minor fixes

bbbf582

Fix unit test snapshot

7399515

Change unknown with N/A for groups and os charts

21d7450

Change unknown with N/A for groups and os charts

85f91bc

Add tooltip when there are no selected agents

90c6e0f

Fix IDs field name

d133a65

Fix result paginations

0613bac

Fix IDs labels

3012807

lucianogorza and others added 2 commits March 19, 2024 14:31

Merge branch '4.9.0' into enhancement/6512-add-filter-for-outdated-ag…

4fc0be0

…ents

Merge branch '4.9.0' into enhancement/6512-add-filter-for-outdated-ag…

8920072

…ents

asteriscos requested changes Mar 21, 2024

View reviewed changes

Fix agents table global actions

fc1ac7f

asteriscos previously approved these changes Mar 21, 2024

View reviewed changes

Desvelao reviewed Mar 22, 2024

View reviewed changes

plugins/main/public/components/endpoints-summary/table/agents-table.test.tsx Outdated Show resolved Hide resolved

Desvelao reviewed Mar 22, 2024

View reviewed changes

plugins/main/public/components/endpoints-summary/table/agents-table.test.tsx Outdated Show resolved Hide resolved

Desvelao reviewed Mar 22, 2024

View reviewed changes

plugins/main/public/components/endpoints-summary/table/agents-table.test.tsx Outdated Show resolved Hide resolved

Desvelao reviewed Mar 22, 2024

View reviewed changes

plugins/main/public/components/endpoints-summary/table/agents-table.tsx Show resolved Hide resolved

JuanGarriuz previously approved these changes Mar 22, 2024

View reviewed changes

Add tooltip to filter switch when there are no outdated agents

16662a4

lucianogorza dismissed stale reviews from JuanGarriuz and asteriscos via 16662a4 March 22, 2024 14:40

Implement WzButton instead EuiSwitch plus EuiToolTip

5be9aba

JuanGarriuz approved these changes Mar 22, 2024

View reviewed changes

Desvelao approved these changes Mar 22, 2024

View reviewed changes

asteriscos merged commit c5824d7 into 4.9.0 Mar 22, 2024
4 checks passed

asteriscos deleted the enhancement/6512-add-filter-for-outdated-agents branch March 22, 2024 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filter for outdated agents #6529

Add filter for outdated agents #6529

lucianogorza commented Mar 18, 2024 •

edited

asteriscos commented Mar 21, 2024

asteriscos left a comment

asteriscos left a comment

JuanGarriuz commented Mar 22, 2024 •

edited

JuanGarriuz left a comment

Desvelao commented Mar 22, 2024 •

edited

lucianogorza commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

Desvelao left a comment

Add filter for outdated agents #6529

Add filter for outdated agents #6529

Conversation

lucianogorza commented Mar 18, 2024 • edited

Description

Issues Resolved

Evidence

Test

Check List

asteriscos commented Mar 21, 2024

asteriscos left a comment

Choose a reason for hiding this comment

asteriscos left a comment

Choose a reason for hiding this comment

JuanGarriuz commented Mar 22, 2024 • edited

Test

JuanGarriuz left a comment

Choose a reason for hiding this comment

Desvelao commented Mar 22, 2024 • edited

lucianogorza commented Mar 22, 2024

Update 22/03/2024

Add tooltip when there are no outdated agents

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

Desvelao left a comment

Choose a reason for hiding this comment

lucianogorza commented Mar 18, 2024 •

edited

JuanGarriuz commented Mar 22, 2024 •

edited

Desvelao commented Mar 22, 2024 •

edited