Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong initial value editing an API connection #6519

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Mar 14, 2024

Description

This pull request fixes a problem with the initial value when editing the API connection.

Issues Resolved

#6201

Evidence

Run as disabled as initial value:
image
image

Run as enabled as initial value:
image
image

Test

6519-fix-run_as-edit-api-connection

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With a API connection with run_as disabled, click on the edit button, the Run as should display as false.
With a API connection with run_as enabled, click on the edit button, the Run as should display as true.

Details

⚫ With a API connection with run_as disabled, click on the edit button, the Run as should display as false.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With a API connection with run_as enabled, click on the edit button, the Run as should display as true.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Mar 14, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 28.94% ( 286 / 988 )
Branches 26.22% ( 107 / 408 )
Functions 26.87% ( 86 / 320 )
Lines 28.68% ( 278 / 969 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@Desvelao Desvelao linked an issue Mar 14, 2024 that may be closed by this pull request
23 tasks
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.83% ( 4093 / 34584 )
Branches 7.49% ( 1697 / 22644 )
Functions 10.5% ( 862 / 8206 )
Lines 12.02% ( 3986 / 33147 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

Uploading image.png…

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit d5636a8 into 4.9.0 Mar 14, 2024
4 checks passed
@Tostti Tostti deleted the fix/6201-editing-api-connection-run-as-wrong-initial-value branch March 14, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the plugin configuration to stateless
3 participants