Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor style improvements #6484

Merged
merged 4 commits into from Mar 7, 2024
Merged

Minor style improvements #6484

merged 4 commits into from Mar 7, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 6, 2024 •
edited

Description

This pull request add some minor fixes.

Issues Resolved

Closes #6483

Evidence

image

Test

  • Change the grey background to #fafbfd00 in
    • Overview
    • SCA
    • App settings
    • Server APIs
  • VirusTotal must have a capital T in the global menu
  • Dashboard management must be the last item of the global meno and Indexer management should be before it.
  • Change duplicated Overview icons

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 6, 2024
@asteriscos asteriscos linked an issue Mar 6, 2024 that may be closed by this pull request
Minor style improvements #6483
Closed
4 tasks
@asteriscos asteriscos marked this pull request as ready for review March 6, 2024 18:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Main plugin code coverage (Jest) test % values
Statements 12.13% ( 4210 / 34699 )
Branches 8.2% ( 1907 / 23256 )
Functions 11.57% ( 957 / 8267 )
Lines 12.3% ( 4098 / 33300 )

lucianogorza
lucianogorza approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image
image
image
image

yenienserrano
yenienserrano approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Details

image

image

image

image

image

@asteriscos asteriscos merged commit 179641b into 4.8.0 Mar 7, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/minor-style-improvements-6483 branch March 7, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor style improvements
3 participants
@asteriscos @yenienserrano @lucianogorza