Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate aws integration tests #25

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Migrate aws integration tests #25

wants to merge 37 commits into from

Conversation

EduLeon12
Copy link

@EduLeon12 EduLeon12 commented Jul 24, 2023 •
edited

Related issue
Closes #36

Description

As part of epic wazuh/wazuh#17788, AWS QA integration tests are being migrated to wazuh core repository.
This PR tends to update the framework to be able to run AWS QA Tests from Wazuh core repository.

Tests

@EduLeon12 EduLeon12 marked this pull request as ready for review August 18, 2023 15:59
@EduLeon12 EduLeon12 self-assigned this Aug 18, 2023
@EduLeon12 EduLeon12 linked an issue Aug 18, 2023 that may be closed by this pull request
Refactor and migrate AWS QA Integration Tests to Core repository wazuh/wazuh#17788
Open
8 tasks
@Selutario Selutario changed the title 17788 migrate aws integration tests Migrate aws integration tests Aug 22, 2023
@EduLeon12 EduLeon12 mentioned this pull request Aug 22, 2023
Open
8 tasks
nico-stefani
nico-stefani previously approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@nico-stefani nico-stefani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Selutario
Selutario reviewed Aug 25, 2023
View reviewed changes
src/wazuh_testing/modules/aws/__init__.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/__init__.py Outdated Show resolved Hide resolved
src/wazuh_testing/constants/paths/configurations.py Outdated Show resolved Hide resolved
TomasTurina
TomasTurina requested changes Aug 28, 2023
View reviewed changes
src/wazuh_testing/constants/paths/configurations.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/__init__.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/__init__.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/__init__.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/event_monitor.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/db_utils.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/exceptions.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/cli_utils.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/s3_utils.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/cloudwatch_utils.py Outdated Show resolved Hide resolved
@EduLeon12 EduLeon12 mentioned this pull request Sep 19, 2023
Closed
3 tasks
@EduLeon12
Copy link
Author

EduLeon12 commented Sep 26, 2023 •
edited

Hi @TomasTurina all changes requested have been made.
I decided to reuse some of the db utils as you pointed out here even tho they have not been pushed to the main branch yet, this will avoid merging issues in the future and allow reusability of the code.

Please, let me know what else should be changed so I can move forward to the core repository refactor.

TomasTurina
TomasTurina requested changes Oct 25, 2023
View reviewed changes
src/wazuh_testing/constants/paths/aws.py Outdated Show resolved Hide resolved
src/wazuh_testing/modules/aws/data_structures.py Outdated Show resolved Hide resolved
@EduLeon12 EduLeon12 force-pushed the 17788-migrate-aws-integration-tests branch from e0a65a4 to 04024fc Compare November 27, 2023 22:17
@EduLeon12 EduLeon12 removed a link to an issue Nov 28, 2023
Refactor and migrate AWS QA Integration Tests to Core repository wazuh/wazuh#17788
Open
8 tasks
TomasTurina
TomasTurina previously approved these changes Nov 29, 2023
View reviewed changes
@TomasTurina
Copy link
Member

Please, change base branch to 4.9.0.

@EduLeon12 EduLeon12 force-pushed the 17788-migrate-aws-integration-tests branch from 5fa911f to 38f0f0d Compare March 4, 2024 13:21
@fdalmaup fdalmaup force-pushed the 17788-migrate-aws-integration-tests branch 5 times, most recently from 2f9ed15 to 7de08b8 Compare April 19, 2024 15:26
@fdalmaup fdalmaup force-pushed the 17788-migrate-aws-integration-tests branch from 7de08b8 to 5dc3229 Compare April 19, 2024 15:33
fdalmaup and others added 12 commits April 19, 2024 17:44
@fdalmaup fdalmaup mentioned this pull request May 15, 2024
Merged
Selutario
Selutario previously approved these changes May 22, 2024
View reviewed changes
TomasTurina
TomasTurina reviewed May 23, 2024
View reviewed changes
Copy link
Member

@TomasTurina TomasTurina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change base to branch 4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTurina TomasTurina TomasTurina left review comments

@Selutario Selutario Selutario left review comments

@nico-stefani nico-stefani Awaiting requested review from nico-stefani

At least 1 approving review is required to merge this pull request.

Assignees

@EduLeon12 EduLeon12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate and refactor AWS module to new qa testing framework
5 participants
@EduLeon12 @TomasTurina @nico-stefani @Selutario @fdalmaup